thegooddocsproject / website-hugo

Hugo based website for the project.
Other
6 stars 22 forks source link

Blogpost #199

Closed kickoke closed 2 years ago

kickoke commented 2 years ago

PR for Issue #131

gitpod-io[bot] commented 2 years ago

kickoke commented 2 years ago

@bwklein If the picture doesn't show up in the local preview (I've used the gitpod setup to generate a preview), does that mean my path is incorrect? Or should the path work after the img magic has run? :)

bwklein commented 2 years ago

@bwklein If the picture doesn't show up in the local preview (I've used the gitpod setup to generate a preview), does that mean my path is incorrect? Or should the path work after the img magic has run? :)

It should show up in local preview if the path is correct. Check the folder path and that the filenames match.

bwklein commented 2 years ago

@kickoke my mistake, I have not made the changes necessary so that the images show up in preview!

I will implement that today, so that they show up in gitpod/local preview and in the netlify deploy preview before being merged into main.

ryanmacklin commented 2 years ago

Made style edits and retitled the post. What I did broadly:

TODO:

ryanmacklin commented 2 years ago

@kickoke Mind looking over the edits, to see if anything I changed doesn't feel like your voice?

ryanmacklin commented 2 years ago

Looking at the image and seeing the filename is "spongebob-writes," I have to ask if this image is public domain or open license? If it isn't, we'll need to source one that is, such as from pexels.com or unsplash.com. [Edit: Or the image can be self-made or permission explicitly granted/gifted to us, as long as we record the acknowledgment in the metadata.]

The ratio for images should be between 1.5 and 2.5 (width / height), with a minimum width of 1000px. I want to favor images that have a ratio of 2 or higher so there's more content above the fold, but looks like we aren't doing that yet, so 1.5 is acceptable.

@kickoke, I'll leave resizing or resourcing the image to you.

ryanmacklin commented 2 years ago

Current blockers:

flicstar commented 2 years ago

Ignorant question: It's not just a matter of setting comments to true on the post?

ryanmacklin commented 2 years ago

Ignorant question: It's not just a matter of setting comments to true on the post?

It might be! This gets to the side matter of having those fields documented (which they might already be somewhere that I'm spacing on).

bwklein commented 2 years ago

I removed commenting and added the Slack channel for people to come have conversations with us there about the posts. If we want commenting in the website and someone wants to sign up to moderate them and reply when comments appear, then I will find a system to do it. In the meantime, I would welcome people into our Slack workspace.

ryanmacklin commented 2 years ago

Makes sense! We can remove the "comment here" on Tina's draft, and leave it to the Twitter mention.

bwklein commented 2 years ago

You could add a line similar to the last sentence in this section.

https://github.com/thegooddocsproject/website-hugo/blob/main/content/en/blog/3-tricks-writers-block.md#putting-this-into-practice

kickoke commented 2 years ago

@ryanmacklin Thank you for your edits! I really love how you shaped my pile of words :D

@bwklein I agree with you on the slack thing, so I added a link :)

kickoke commented 2 years ago

@ryanmacklin Regarding the copyright of the image: I found it on twitter, from the official Spongebob account. Would it suffice to link to the original tweet?

Edit: I've chosen another picture that captures the spirit of new beginnings. Another cup pic, it might become our thing 😁