thegooglecodearchive / allforgood

Automatically exported from code.google.com/p/allforgood
0 stars 0 forks source link

Tab level opp count should only update on tab that is active when applying "Refine by" facet filtering #596

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Tab level opp counts get updated when applying Refine by filtering.  See below 
email notes:

As I’m starting to try using the new SERP tab setup with the Refine by 
facets, I’m realizing that other than date, geo proximity, and location 
changes, carrying the Refine by selections across tabs will get super weird.  
It looks like you are having those Refine by facet selections get reset when a 
tab is changed which makes sense.  (Nice thinking ahead of me there.  I like 
that.)  What I also think may make sense is not having the counts in the top 
level tabs get updated when a tab specific Refine by facet is applied.  Just 
don’t bother with updating those values on the other tabs if we are 
automatically going to reset the facet selections anyway.  It seems weird to 
select Refine by DIY when on that tab, then see the other tab values go to 
zero.  But then when you go to one of the other tabs the Refine by gets reset.  
Just don’t bother updating tab level counts based on Refine by selections. 
(but do based on geo selection or date) That would also cut down on hits to 
Solr and perhaps complexity of getting everything working right.  What do you 
think?

Original issue reported on code.google.com by danstryk...@gmail.com on 18 Mar 2011 at 3:06

GoogleCodeExporter commented 9 years ago
Change tab level counts to be four separate queries. Do not update tab level 
counts when facets are applied, but do update when new search term is entered 
and if date is changed update geo, virtual, micro, but not DIY.  if location or 
radius is changed only update geo tab counts 

Original comment by danstryk...@gmail.com on 18 Mar 2011 at 8:15

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Dan, I made an update to echoditto for the tab counts updating. If the new code 
is acceptable I will mark the ticket as resolved. Thanks.

Original comment by jwdemp...@gmail.com on 31 Mar 2011 at 7:12

GoogleCodeExporter commented 9 years ago
verified tab level opp counts do not update in UI when refining by facets.

Original comment by danstryk...@gmail.com on 1 Apr 2011 at 7:36

GoogleCodeExporter commented 9 years ago
Fix needs to be tweaked.

tab level counts are not updating when a new search term is entered or when the 
date range is changed. that should occur.  Need to if user hits enter/clicks 
green search button in search term bar or if user clicks the green "update 
search" button" underneath the facet controls refresh the tab level opp counts.

http://echoditto.latest.footprint2009dev.appspot.com/search#q=dog&num=10&start=1
&vol_loc=20001&distance=25&type=all&sort=Relevance&timeperiodstart=start%20date&
timeperiodend=end%20date&cache=1 

Original comment by danstryk...@gmail.com on 4 Apr 2011 at 2:55

GoogleCodeExporter commented 9 years ago
The tab level counts are now updated when a new search term is entered, when 
the date is changed, and when the update search button is clicked.

Original comment by jwdemp...@gmail.com on 4 Apr 2011 at 3:35

GoogleCodeExporter commented 9 years ago
verified fixed.

Original comment by danstryk...@gmail.com on 4 Apr 2011 at 5:15