search

thegooglecodearchive / django-grappelli

Automatically exported from code.google.com/p/django-grappelli
Other
0 stars 0 forks source link

Tabular inline: multiple CSS classes where there should only be one #364

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Which DJANGO-VERSION are you using?
1.3

Which GRAPPELLI-VERSION are you using?
r1428

Which BROWSER (including the version) are you using?
Doesn't matter

------------

Just noticed today that Grappelli doesn't remove spaces in field.label in the 
th-class in tabular.html, thus creating several classes where there should only 
be one. See my diff for fix.

Speaking of which, you should really look into namespacing your css-classes. 
The reason I found this bug today was because i had a field named "base_module" 
which was turned into:
<div class=th base module required">Base module</div>
and as "module" is one of the class names you use I got the same 938px 
min-width on the th-element as on "module".

Original issue reported on code.google.com by m...@jacobian.se on 27 Apr 2011 at 1:24

Attachments:

GoogleCodeExporter commented 9 years ago 
fixed with r1439. namespacing is on our todo-list for the next major version.

Original comment by sehmaschine on 28 May 2011 at 3:10