thegooglecodearchive / los-cocos

Automatically exported from code.google.com/p/los-cocos
0 stars 0 forks source link

Move forced colon on cocos.menu.MultipleMenuItem to keyword arg in __init__? #37

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In menu.py, at line 415 (rev. 461):

Can the forced colon be dropped from _get_label on MultipleMenuItem?  Or at
least set by a keyword argument (i.e. __init__(..., separator=": ", ...).  

It would be nice to have full control over the menu item presentation.

Original issue reported on code.google.com by david....@gmail.com on 22 Apr 2008 at 2:50

GoogleCodeExporter commented 9 years ago
What about being part of the name (to simplify the thing) ?

Original comment by ricardoq...@gmail.com on 22 Apr 2008 at 6:15

GoogleCodeExporter commented 9 years ago
In other words, you'd have to put ": " at the end of the string you pass to 
label? 
This makes plenty of sense to me.  

I had suggested the keyword arg to preserve backward compatibility, but I 
suppose you
guys aren't too worried about that yet. :)

Original comment by david....@gmail.com on 22 Apr 2008 at 6:23

GoogleCodeExporter commented 9 years ago
i believe that backwards compatibility will be an issue from now on. actually, 
i hope
so. at least, a bit more stable on the core api.

Original comment by lucio.to...@gmail.com on 22 Apr 2008 at 6:35

GoogleCodeExporter commented 9 years ago
fixed. rev 463

Original comment by ricardoq...@gmail.com on 22 Apr 2008 at 6:43