search

thegraphnetwork / EpiGraphHub

Software platform to Gather, transmform, harmonize and store epidemiological data for analytical purposes.
https://epigraphhub.org
GNU General Public License v3.0
8 stars 10 forks source link

Update superset version #142

Closed esloch closed 2 years ago

esloch commented 2 years ago

Resolve #140.

xmnlab commented 2 years ago

LGTM! let's wait for the CI before merging this PR! thanks for working on that @esloch !

xmnlab commented 2 years ago

I think we should have a specific conda environment file for superset and another one for airflow.

the superset file should contain just the dependencies for superset.

the airflow file should include the epigraphhub(_py) dependency and maybe the other dependencies as defined by prod.yaml.

not sure now about the R dependencies, because right now we don't have any R code running on the airflow container.

@fccoelho we need to discuss again about the R package. Also, maybe we could discuss again the multi api approach: https://github.com/thegraphnetwork/epigraphhub-enhancement-proposals/pull/1/files#diff-6239aab7993539c8ff8b64897e61817500667bc35e547d8be4365f311faac79d (of course, it is not something for this PR)