search

thegraphnetwork / epigraphhub_py

Epigraphhub Python package
GNU General Public License v3.0
2 stars 9 forks source link

BREAKING CHANGE: Changes in the code to allow the use of version 0.3.12 of ngboost. #167

Closed eduardocorrearaujo closed 2 years ago

eduardocorrearaujo commented 2 years ago

Description

This PR was created to allow the use of version 0.3.12 of ngboost. This PR also aims to solve issue #166. To deal with this issue, I created functions assigned with article at the end of the name to use the data saved in the data folder and allow the reproductions of the results shown in the article (that will be used as an example in our repo).

eduardocorrearaujo commented 2 years ago

I started to make the changes suggested by @xmnlab in #168. I also created the forecast_models.py file to integrate the forecast with the airflow.

When running the forecast_models.py, I receive the error: ModuleNotFoundError: No module named 'epigraphhub'. There is any package used to help the code to find the file as: sys.path.add('...') (I tried add it but didn't work)?

eduardocorrearaujo commented 2 years ago

If you don't ask for any change we could finish this PR, so I could start to work on the issue #168

xmnlab commented 2 years ago

I receive the error: ModuleNotFoundError: No module named 'epigraphhub'

@eduardocorrearaujo do you still have this problem?

btw, it seems you will need to rebase your branch on top of the main branch.

fccoelho commented 2 years ago

@eduardocorrearaujo please check if we can unpin the numpy version. It is still on version 1.20.3 while the current version is already on 1.23.2

xmnlab commented 2 years ago

is it ready for the merge?

fccoelho commented 2 years ago

LGTM! @eduardocorrearaujo ?

eduardocorrearaujo commented 2 years ago

I will just run the notebooks in the tutorials folder again to make sure the rebase didn't break any thing and so I will make the merge and the release.