thegraphnetwork / epigraphhub_py

Epigraphhub Python package
GNU General Public License v3.0
2 stars 9 forks source link

feat: Add settings module for environment variable #169

Closed xmnlab closed 2 years ago

xmnlab commented 2 years ago

Description

This PR aims to add a configuration mechanism that will allow us to use epigraphhubpy with local databases.

Additionally, this PR proposes to:

Related Issue

Checklist

Note: The title prefix can be also expanded with more information inside the parenthesis. Some examples for a full title (prefix + message):

xmnlab commented 2 years ago

@fccoelho @eduardocorrearaujo this PR is ready for review. I hope that the CI will work now, otherwise I will take a look into that later.

@esloch @luabida also, if you have time for review this PR, that would be great.

thanks!

xmnlab commented 2 years ago

@fccoelho thank you so much for your review, really appreciate that :) If you want we could have a quick call this week to discuss these points!

thank you!

xmnlab commented 2 years ago

as it was already approved, I will move it forward and merge it! thanks @fccoelho and @luabida for the review!

the current PR is failing now just because we hit the limit for the gtrends tests: https://github.com/thegraphnetwork/epigraphhub_py/pull/169/checks#step:8:92