thegraphnetwork / epigraphhub_py

Epigraphhub Python package
GNU General Public License v3.0
2 stars 9 forks source link

[fix] Update poetry and pyproject to ngboost-release #180

Closed eduardocorrearaujo closed 1 year ago

eduardocorrearaujo commented 1 year ago

Description

Change ngboost to ngboost-release

Checklist

Note: The title prefix can be also expanded with more information inside the parenthesis. Some examples for a full title (prefix + message):

xmnlab commented 1 year ago

@eduardocorrearaujo you need to remove also the current ngboost: https://github.com/thegraphnetwork/epigraphhub_py/pull/180/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R58

poetry remove ngboost

xmnlab commented 1 year ago

Maybe you would need to remove poetry lock and run again poetry install locally. Maybe there is already a command for that, maybe poetry lock .. but I am not sure

xmnlab commented 1 year ago

@eduardocorrearaujo what is the status of this PR? do you need any help?

eduardocorrearaujo commented 1 year ago

@eduardocorrearaujo what is the status of this PR? do you need any help?

Yes. I don't know why the build is falling. Before I do the commits, the install dependencies tests were passing, but an error was given in one of the tests of the world_data_bank script.

Since this test was running on my local machine, I thought that could be a problem with the wbgapi version used. So, I typed poetry add wbgapi==1.0.7 and did the commit, but after it, the code started to break again in the install dependencies tests.

xmnlab commented 1 year ago

ok I will take a look into that in a bit

eduardocorrearaujo commented 1 year ago

Hi, @fccoelho, following the recommendations in the meeting, I skipped the tests in the world bank, and now the CI is passing. After the merge, I will open an issue to solve this problem with the world bank. It seems that had some changes in how to get the data from there.

xmnlab commented 1 year ago

thanks @eduardocorrearaujo for working on that!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: