Closed eduardocorrearaujo closed 1 year ago
@eduardocorrearaujo you need to remove also the current ngboost: https://github.com/thegraphnetwork/epigraphhub_py/pull/180/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R58
poetry remove ngboost
Maybe you would need to remove poetry lock and run again poetry install locally. Maybe there is already a command for that, maybe poetry lock .. but I am not sure
@eduardocorrearaujo what is the status of this PR? do you need any help?
@eduardocorrearaujo what is the status of this PR? do you need any help?
Yes. I don't know why the build is falling. Before I do the commits, the install dependencies tests were passing, but an error was given in one of the tests of the world_data_bank
script.
Since this test was running on my local machine, I thought that could be a problem with the wbgapi
version used. So, I typed poetry add wbgapi==1.0.7
and did the commit, but after it, the code started to break again in the install dependencies tests.
ok I will take a look into that in a bit
Hi, @fccoelho, following the recommendations in the meeting, I skipped the tests in the world bank, and now the CI is passing. After the merge, I will open an issue to solve this problem with the world bank. It seems that had some changes in how to get the data from there.
thanks @eduardocorrearaujo for working on that!
:tada: This PR is included in version 1.2.1 :tada:
The release is available on:
1.2.1
Your semantic-release bot :package::rocket:
Description
Change ngboost to ngboost-release
Checklist
CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.chore(docs):
for Examples / docs / tutorials / dependencies updatefix:
for a bug fix (non-breaking change which fixes an issue).chore(improvement):
for an improvement (non-breaking change which improves an existing feature).feat:
for a new feature (non-breaking change which adds functionality).breaking change:
for a breaking change (fix or feature that would cause existing functionality to change).chore(security):
for a security fix.Note: The title prefix can be also expanded with more information inside the parenthesis. Some examples for a full title (prefix + message):
fix(login): Fix the login page
.feat(forecast): Add a weather forecast page
.chore(security-login): Add a weather forecast page
.