search

thegraphnetwork / epigraphhub_py

Epigraphhub Python package
GNU General Public License v3.0
2 stars 9 forks source link

Epitools, draft of PR #201

Closed NicoRicardi closed 1 year ago

NicoRicardi commented 1 year ago

Description

All functions reproduce the results from the R implementation. I can make tests quite quickly. Still, a lot of functions are not implemented yet.

For docstring and documentation, should we write a detailed one or refer to the R docs? I feel like the former would be a lot of work because of how bare-bon the R docs are

fccoelho commented 1 year ago

@NicoRicardi please add unit tests for these functions

fccoelho commented 1 year ago

thanks @NicoRicardi ! I'll review it ASAP.

github-actions[bot] commented 1 year ago

Stale pull request message

fccoelho commented 1 year ago

@eduardocorrearaujo Could you take over this PR? There is no need to implement new things, just to address the comments I made to the codebase and turn this into a usable module, even though it may be incomplete compared to R Epitools, for now.

eduardocorrearaujo commented 1 year ago

@eduardocorrearaujo Could you take over this PR? There is no need to implement new things, just to address the comments I made to the codebase and turn this into a usable module, even though it may be incomplete compared to R Epitools, for now.

Yes, I will look at it at the weekend.

github-actions[bot] commented 1 year ago

Stale pull request message