search

thegreenrobot / pagerduty_dashing

A Dashing dashboard for PagerDuty Services & Schedules
MIT License
44 stars 23 forks source link

Feature request: A User can deploy Dashing, with PD widgets included, to a heroku instance using a GUI #15

Closed chrisgagne closed 9 years ago

chrisgagne commented 9 years ago

Please check out: https://github.com/stripe/pagerbot

There's a "Deploy to Heroku" button at the top. We'd love it if a user could deploy Dashing—with PD widgets included—to a Heroku instance much the same way PagerBot does. We'd be happy to offer a bounty for the work... :)

thegreenrobot commented 9 years ago

@chrisgagne This sounds like a nice idea. I'll give a try.

thegreenrobot commented 9 years ago

@chrisgagne Success!

Please take a look PR https://github.com/thegreenrobot/pagerduty_dashing/pull/16 and https://github.com/thegreenrobot/pagerduty_dashing/tree/heroku_push_button

I was able to deploy to Heroku with the push button without any issue.

Please give it a test and let me know if you have any questions.

Thanks!

p.s. What kind of bounty were you thinking? :grinning:

dshack commented 9 years ago

Hi @thegreenrobot, looks awesome!

However, I get "Application Error" when I try to deploy. Am I configuring correctly?

image

Application Error An error occurred in the application and your page could not be served. Please try again in a few moments. If you are the application owner, check your logs for details.

I've tried a few other JSON formats, but none seem to work. Ideas?

thegreenrobot commented 9 years ago

Hi @dshack.

I just tried deploying this several times.

1st deploy: I tried it with the services/schedules with no line breaks and it deployed successfully.

{"services": { "staging": "ABC1234","preprod": "QAZ4567","production": "EDC4321"}}
{"schedules": { "oncall": "ABC1234","firefighter": "QAZ4567"}}

2nd deploy: I tried it with the services/schedules with line breaks like you tried and it failed to deploy and Heroku gave the message "unknown error contact support".

{
    "schedules": {
        "oncall": "ABC1234",
        "firefighter": "QAZ4567"
    }
}

3rd deploy: I tried it again with line breaks in the hopes that maybe Heroku was just having a momentarily bad day. Failed again with the same message.

4th deploy: I went back to defining the services/schedules without any line breaks in the json and it deployed successfully.

5th deploy: I changed my services/schedules json so there was only one service and schedule (like yours) but without any line breaks and it deployed successfully.

From what I've seen so far, Heroku does not like having line breaks in your config vars.

Thanks,

Matt

dshack commented 9 years ago

@thegreenrobot verified, makes sense. Thanks! I'll email Heroku support about this. Also, we'll be sending a present your way that I think you'll like :)

thegreenrobot commented 9 years ago

@dshack

Sounds good! I will get this merged later today.

Thanks!

Matt

thegreenrobot commented 9 years ago

Closing out this feature request as the deploy to Heroku button feature is now live.

Thanks @chrisgagne and @dshack for the request. :smiley: