search

thegreenter / xmldsig

Firma digital en Facturación Electrónica
BSD 3-Clause "New" or "Revised" License
37 stars 14 forks source link

Values for getValidFrom() and getExpiration() are switched #7

Closed lurifuchs closed 5 years ago

lurifuchs commented 5 years ago

Then functions getValidFrom() and getExpiration() in class x509Certificate.php seems to have returned values switched. getValidFrom() returns validTo_time_t and getExpiration() returns validFrom_time_t.

getValueFrom() should return value for validFrom_time_t.

giansalex commented 5 years ago

Thanks @davidajnered, i go to fix it.

lurifuchs commented 5 years ago

Thank you for the quick fix! Can you release a new version on packagist as well? :)

giansalex commented 5 years ago

Yes, ready!

lurifuchs commented 5 years ago

Best support ever! Thank you :)