refactor: replace unnamed functions with arrow callbacks

thegreenwebfoundation / co2.js

An npm module for accessing the green web API, and estimating the carbon emissions from using digital services

https://developers.thegreenwebfoundation.org/

Other

414 stars 54 forks source link

Closed Fdawgs closed 2 years ago

Fdawgs commented 2 years ago

This PR:

Replaces unnamed functions with arrow callbacks; arrow callbacks are already in use in the repo, and this saves a few bits/bytes by using less loc
Removes already declared variables in sustainable-web-design.test.js; averageWebsiteInBytes is declared further up in the scope on line 5
Enables the eslint-plugin-jest dev dependency rules in .eslintrc.json and fixes errors thrown by that plugin

mrchrisadams commented 2 years ago

Thanks for this @Fdawgs. I'd like to leave @drydenwilliams a day or so to look over this before I merge this in, as it touches code he authored.

I'm happy with this though, and this seems pretty uncontroversial. I'll merge in end of Tuesday, if there's no further comment.