thegridelectric / gw-scada-spaceheat-python

GridWorks SCADA for space heating
MIT License
5 stars 2 forks source link

garage config changes - only one tank temp sensor #53

Closed jessicamillar closed 2 years ago

jessicamillar commented 2 years ago

The five 1-wire Adafruit 642 temperature sensors inside the big Axeman water tank were failing in a variety of ways. We think water was getting into the electronics inside one or more of the sensors themselves, through the (attempted waterproof) splicing job we had done.

So George pulled them out, and replaced them with a single Adafruit 642 which is up near the top. That means a.tank.temp1 .. a.tank.temp4 no longer exist as nodes, and a.tank.temp0 has a new component.

codecov[bot] commented 2 years ago

Codecov Report

Merging #53 (df09a57) into main (658ea54) will decrease coverage by 0.05%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   70.74%   70.69%   -0.06%     
==========================================
  Files         118      118              
  Lines        3934     3934              
==========================================
- Hits         2783     2781       -2     
- Misses       1151     1153       +2     
Impacted Files Coverage Δ
gw_spaceheat/actors/scada.py 69.07% <0.00%> (-1.32%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more