Closed jessicamillar closed 2 years ago
Merging #61 (866d43f) into main (b04455d) will decrease coverage by
3.88%
. The diff coverage is6.45%
.
@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 71.65% 67.76% -3.89%
==========================================
Files 128 128
Lines 4290 4297 +7
==========================================
- Hits 3074 2912 -162
- Misses 1216 1385 +169
Impacted Files | Coverage Δ | |
---|---|---|
gw_spaceheat/actors/scada.py | 63.37% <0.00%> (-10.47%) |
:arrow_down: |
test/test_examples.py | 81.48% <6.66%> (-18.52%) |
:arrow_down: |
...t_sh_status_snapshot/gt_sh_status_snapshot_base.py | 28.26% <0.00%> (-47.83%) |
:arrow_down: |
...li_scada_response/gt_sh_cli_scada_response_base.py | 45.00% <0.00%> (-45.00%) |
:arrow_down: |
...i_scada_response/gt_sh_cli_scada_response_maker.py | 40.62% <0.00%> (-40.63%) |
:arrow_down: |
...ema/gt/gt_sh_cli_atn_cmd/gt_sh_cli_atn_cmd_base.py | 50.00% <0.00%> (-38.89%) |
:arrow_down: |
...ma/gt/gt_sh_cli_atn_cmd/gt_sh_cli_atn_cmd_maker.py | 43.33% <0.00%> (-36.67%) |
:arrow_down: |
..._sh_status_snapshot/gt_sh_status_snapshot_maker.py | 34.14% <0.00%> (-34.15%) |
:arrow_down: |
...t/schema/gt/gt_sh_cli_atn_cmd/gt_sh_cli_atn_cmd.py | 55.55% <0.00%> (-33.34%) |
:arrow_down: |
.../gt/gt_sh_status_snapshot/gt_sh_status_snapshot.py | 55.55% <0.00%> (-33.34%) |
:arrow_down: |
... and 8 more |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
When a TelemetryValue was 0 (as opposed to None), the scada still includes it in the status snapshot.
replace if
self.latest_reading[node]
with ifself.latest_reading[node] is not None