search

thegridelectric / gw-scada-spaceheat-python

GridWorks SCADA for space heating
MIT License
5 stars 2 forks source link

Jm/better simple sensor #74

Closed jessicamillar closed 2 years ago

jessicamillar commented 2 years ago

Create testable, documented methods in simple sensor.

Note that the down-side is that we are not reporting asynchronously on change as fast as possible. For SimpleSensors, which pretty much live in IoT space, this does not matter.

codecov[bot] commented 2 years ago

Codecov Report

Merging #74 (895223f) into main (70d23ec) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   71.36%   71.39%   +0.02%     
==========================================
  Files         134      134              
  Lines        4480     4481       +1     
==========================================
+ Hits         3197     3199       +2     
+ Misses       1283     1282       -1
Impacted Files Coverage Δ
gw_spaceheat/actors/simple_sensor.py 97.95% <100.00%> (+2.40%) :arrow_up:
test/test_examples.py 95.67% <100.00%> (-0.07%) :arrow_down:
gw_spaceheat/actors/scada.py 62.94% <0.00%> (-1.18%) :arrow_down:
.../drivers/temp_sensor/unknown_temp_sensor_driver.py 84.61% <0.00%> (+7.69%) :arrow_up:
...ipe_flow_sensor/unknown_pipe_flow_sensor_driver.py 84.61% <0.00%> (+7.69%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more