thegridelectric / gw-scada-spaceheat-python

GridWorks SCADA for space heating
MIT License
5 stars 2 forks source link

Settings object with Pydantic #99

Closed anschweitzer closed 2 years ago

anschweitzer commented 2 years ago

Setting read from environment and .env files with pydantic, and explicitly constructed and passed around, not automatically constructed on import.

TL, DR: Check out config.py and this and this.

This PR is probably ok to merge without much or any review, but it touches a lot of files and has some opinionated style changes which you might care about.

Changes include:

The README is not yet updated. If the other changes look good to you (or we just decide to merge without review), I'll update README.

anschweitzer commented 2 years ago

PR also now includes a few protocol tests. To view only those changes, look here.

Added:

anschweitzer commented 2 years ago

Thanks for reminding me. I went to read about typer and got distracted.