search

thegrizzlylabs / sardine-android

A WebDAV library for Android
Apache License 2.0
355 stars 70 forks source link

Deprecation warnings on setCustomProps and getResources #25

Open Derpalus opened 5 years ago

Derpalus commented 5 years ago

Hello!

I'm getting deprecation warnings on setCustomProps and getResources in OkHttpSardine.java. Apparently, the functions they override have been deprecated in Sardine.

guillaume-tgl commented 5 years ago

Yes, as mentioned in the comments, it's better to use list instead of getResources and patch instead of setCustomProps.

Derpalus commented 5 years ago

Of course, however, I was thinking about Android Studio Lint complaining about deprecation and even failing release compilations if these warnings remain (even if not actually using the functions). A simple way of fixing them is to just mark the functions in question as deprecated in turn.

guillaume-tgl commented 5 years ago

Ok, I understand. This comes from the legacy Sardine library so I've never really thought about it. I'm not against removing these deprecated methods, both in the interface and in the class, or simply annotate them as deprecated. Do you want to make a PR?

Derpalus commented 5 years ago

Well, I'm currently just using this project in an app, I don't have it checked out or am particularly good at using GitHub, so perhaps it's easier if you do it so it gets done correctly.