thegrumpys / odop

Open Design Optimization Platform (ODOP) - Coil spring design app; mechanical springs; compression spring, extension spring, torsion spring
https://www.springdesignsoftware.org
MIT License
4 stars 5 forks source link

Improve consistency of spring weight calculations #564

Closed grumpyinca closed 2 years ago

grumpyinca commented 3 years ago

Spring weights are calculated separately in eqnset and reports (ReportBase). In compression & torsion design types there are significant differences. The comments in the code note that the eqnset calculations are "crude" and the report calculations are "more accurate". The differences are greatest for compression springs with a large pitch and torsion springs with a large Coil_Spacing.

Perhaps the best approach to resolving the discrepancy is to move the more accurate calculation into each eqnset. That will put the value into the symbol table (the model) where it can be accessed in the reports without recalculation.

1fifoto commented 2 years ago

Merge into master, closing