thegrumpys / odop

Open Design Optimization Platform (ODOP) - Coil spring design app; mechanical springs; compression spring, extension spring, torsion spring
https://www.springdesignsoftware.org
MIT License
4 stars 5 forks source link

initialState changes after initial integration of validity #698

Closed grumpyinca closed 2 years ago

grumpyinca commented 2 years ago

This issue was originally titled: "Improve default MAX constraint on compression spring Slenderness"

The scope is now expanded to include:

The default MAX constraint for compression spring Slenderness should change from the current 10.0 to 4.0. That will allow simply enabling the constraint in order to design a spring with reduced risk of buckling. The user will not have to know the details.

Migrate on any of these items is likely not desirable. Saved designs should keep their old value.

grumpyinca commented 2 years ago

Wow! ... That didn't work out so well. It seems that I am re-learning old lessons.

In compression and torsion, the Deflect_1 validmin is set to -number.MAX_VALUE. The key point is that the Deflect_1 MIN constraint was not really made redundant by the validity checking. With the constraint on Deflect_1 removed, nothing stops Search and Seek from going for spectacularly negative values of force & deflection at the first load point. So, in the initialState files for compression & torsion, I have re-enabled the Deflect_1 default lmin of CONSTRAINED. The changes have been pushed into master and branch 703.

Note that the extension spring Deflect_1 validmin is set to -number.MIN_VALUE so there is (hopefully) not a similar run-away issue there.

grumpyinca commented 2 years ago

Closing. Future v4.3 changes in branch #703.