thegrumpys / odop

Open Design Optimization Platform (ODOP) - Coil spring design app; mechanical springs; compression spring, extension spring, torsion spring
https://www.springdesignsoftware.org
MIT License
4 stars 5 forks source link

Post validity-integration tweaks #703

Closed grumpyinca closed 2 years ago

grumpyinca commented 2 years ago

This issue is intended to provide a branch supporting a range of small-scale changes applied after the validity changes of branches 590 and 569.

Changes associated with Alerts.js, AlertsModal.js & Help/Alerts.md:

Also include:

Update new Patsh.js:

1fifoto commented 2 years ago

Also consider adding to patsh: s + tol * Math.abs(ssi) >= ssi

grumpyinca commented 2 years ago

Validity and Alert handling before & after Search, Seek & Trade

Before Search

After Search This section moved to issue #705.

Before Seek

After Seek This section moved to issue #705.

Before Trade Add same tests as before Search. This section moved to issue #705.

After Trade This section moved to issue #705.

1fifoto commented 2 years ago

Merged into master.

grumpyinca commented 2 years ago

Issue #698 is now closed. Ongoing initialState changes being handled as part of this issue.

Specifically, Allow User_Specified End_IDs & L_Ends to be 0 w/o invalid alert.

grumpyinca commented 2 years ago

Added alerts for Cycle_Life for case when Prop_Calc_Method > 1 and also case where FS_2 < 1.0.

grumpyinca commented 2 years ago

Changes in the past several days:

These changes resulted in merge conflicts versus branch #707. It appears that it is time to close this branch and move on to a greater number of new and short-lived issues based on the then current master.

Merged to master. Pushed to remote. Closing.