search

thegrumpys / odop

Open Design Optimization Platform (ODOP) - Coil spring design app; mechanical springs; compression spring, extension spring, torsion spring
https://www.springdesignsoftware.org
MIT License
4 stars 5 forks source link

Review FS_1 when Force_1 = 0 #719

Closed grumpyinca closed 2 years ago

grumpyinca commented 2 years ago

Need to re-examine the calculation of FS_1 when Force_1 (M_1) is zero for all spring types and all views.

grumpyinca commented 2 years ago

When Force_1 = 0, compression & extension springs show stale FS_1 value in Calculator View only.

When M_1 = 0, torsion spring shows FS_1 as zero in Calculator View, and all three reports.

grumpyinca commented 2 years ago

I repaired a coding problem in each of the spring types & pushed into this branch. As of this writing, the stale FS_1 value in Calculator View is the only known remaining problem.

Separately, there are a couple of cleanup items (for example, "infinite" versus "infinity") that I plan to deal with before closing this issue.

1fifoto commented 2 years ago

Fixed display of fs_1 in Compression Calculator view by changing the Value component to display 'Infinity' or '-Infinity' via toFixed function call.

Make Calculator view of Static FS Free to be right-justified 'Infinity'

grumpyinca commented 2 years ago

Move "allowable stress for preset" line into comment block. Remove comment re tensile values now superseded by alert.

grumpyinca commented 2 years ago

Merged to master. Pushed to remote. Closing.