search

thegrumpys / odop

Open Design Optimization Platform (ODOP) - Coil spring design app; mechanical springs; compression spring, extension spring, torsion spring
https://www.springdesignsoftware.org
MIT License
4 stars 5 forks source link

FIXing var w/ default constraint triggers alert #728

Closed grumpyinca closed 2 years ago

grumpyinca commented 2 years ago

Fixing a variable configured with a default constraint will trigger a "Warn: Default constraint has been disabled." alert.

While not a blatant bug, this is not desirable. The conditional that triggers the alert should be modified to not generate this alert in the case that a FIX is present.

grumpyinca commented 2 years ago

Perhaps it would be best to defer work on this issue until #726 is complete. When working in development with v4.3rc2, I am having difficulty reproducing this issue.

Is the following line the correct / best syntax ? if (!(design.model.symbol_table[o.Coils_A].lmin & CONSTRAINED) && !(design.model.symbol_table[o.Coils_A].lmin & FIXED)) add_DCD_alert(design.model.symbol_table[o.Coils_A], '');

1fifoto commented 2 years ago

No longer a problem. Fixed in #726. Closing.

grumpyinca commented 2 years ago

See changes made in #744.