search

thegrumpys / odop

Open Design Optimization Platform (ODOP) - Coil spring design app; mechanical springs; compression spring, extension spring, torsion spring
https://www.springdesignsoftware.org
MIT License
4 stars 5 forks source link

Make Common Spring Alerts Checks #744

Closed 1fifoto closed 2 years ago

1fifoto commented 2 years ago

In Compression, Extension and Torsion directory have its checks.js call a "checks as springChecks" in the Spring directory. Then in Spring directory have its checks.js call a "checks as commonChecks" from Alerts file.

1fifoto commented 2 years ago

We cannot do this function (of creating a common Spring checks.js) in this issue, because the common Spring checks.js needs access to the specific spring type's symboltable.js file. Instead this issue became changes to make the code better structured and to check and return immediately if the element default MIN/MAX constraint is FIXED.

We have left the issue's title to be the original request, because maybe sometime in the future it can actually be implemented.

1fifoto commented 2 years ago

Merged into master, closing