search

thegrumpys / odop

Open Design Optimization Platform (ODOP) - Coil spring design app; mechanical springs; compression spring, extension spring, torsion spring
https://www.springdesignsoftware.org
MIT License
4 stars 5 forks source link

Review alerts to make conditional on constraints. #754

Open grumpyinca opened 1 year ago

grumpyinca commented 1 year ago

Review all alerts to determine if operation would be improved by making them conditional on a related constraint being enabled.

Example: The "Cycle_Life value is extrapolated" alert was appearing more frequently than desired. It was made conditional on an enabled (MIN or MAX) constraint on Cycle_Life to resolve the concern.

From checks.js:

if ((design.model.symbol_table[o.Cycle_Life].lmin & CONSTRAINED && design.model.symbol_table[o.Cycle_Life].value < 1e+4) 
 || (design.model.symbol_table[o.Cycle_Life].lmax & CONSTRAINED && design.model.symbol_table[o.Cycle_Life].value > 1e+7)) {
            addAlert({ ...