thegrumpys / odop

Open Design Optimization Platform (ODOP) - Coil spring design app; mechanical springs; compression spring, extension spring, torsion spring
https://www.springdesignsoftware.org
MIT License
4 stars 5 forks source link

Trade doesn't return feasible design when NOT APPROPRIATE is detected #777

Open grumpyinca opened 1 year ago

grumpyinca commented 1 year ago

The original Trade algorithm was modified to immediately run Search in order to test for the availability of a feasible design. If a feasible design is available, Trade returns the message "OBJ < OBJMIN - USE OF TRADE IS NOT APPROPRIATE".

The concern of this issue is that it appears that Trade does not return the feasible design that was discovered by Search. Rather, it appears that Trade returns its original (infeasible) start point.

The first question is: "Which design should Trade return?".

There is opportunity for confusion when the user sees the "OBJ < OBJMIN ..." part of the message and the multi-color feasibility indicator is pointing in the red zone. It seems logical that if a feasible design is available, Trade would return it. However, there may be other factors that dictate the current operation.

The following exported design may be helpful in replicating the behavior. It will be necessary to expand the .zip file in order to change the file type back to .json.

TradeNotAppropriate.zip