thegrumpys / odop

Open Design Optimization Platform (ODOP) - Coil spring design app; mechanical springs; compression spring, extension spring, torsion spring
https://www.springdesignsoftware.org
MIT License
4 stars 5 forks source link

Fix FileImport Issues #909

Closed 1fifoto closed 1 month ago

1fifoto commented 5 months ago

Secondary problem with FileImport does not show the filename instead it shows "undefined". Change from migrated_design.name to filename.

if (migrated_design.jsontype === "ODOP") {
  dispatch(load(migrated_design));
  dispatch(changeName(filename));
  dispatch(deleteAutoSave());
  logUsage('event', 'FileImport', { event_label: migrated_design.type + ' ' + migrated_design.name });
} else {
  displayMessage('Invalid JSON type, function ignored');
}

to

if (migrated_design.jsontype === "ODOP") {
  dispatch(load(migrated_design));
  dispatch(changeName(filename));
  dispatch(deleteAutoSave());
  logUsage('event', 'FileImport', { event_label: migrated_design.type + ' ' + filename });
} else {
  displayMessage('Invalid JSON type, function ignored');
}
1fifoto commented 5 months ago

Change displayMessage text from

  const onError = (e) => {
//    console.log('In FileImport.onError e=',e);
    displayMessage('GET of design names failed with message: \'' + fileReader.error.message + '\'');
    displaySpinner(false);
  }

to

  const onError = (e) => {
//    console.log('In FileImport.onError e=',e);
    displayMessage('Read of Import File failed with message: \'' + fileReader.error.message + '\'');
    displaySpinner(false);
  }
1fifoto commented 5 months ago

Reorder file read operation. Set on handlers before doing the read. Change from

fileReader.readAsText(selectedFile); // Begin Reading Text File
fileReader.onloadend = onLoadEnd; // On Load End callback
fileReader.onError = onError; // On Error callback

to

fileReader.onloadend = onLoadEnd; // On Load End callback
fileReader.onError = onError; // On Error callback
fileReader.readAsText(selectedFile); // Begin Reading Text File
1fifoto commented 1 month ago

Merged into 441, closing