thehadeeryounis / ss-scrum-tool

Automatically exported from code.google.com/p/ss-scrum-tool
0 stars 0 forks source link

As a Scrum Master/ Project Admin I can change the status of the meeting attendees #18

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Success Scenarios:

Scenario 1 : change status successfully : Given the Scrum Master/Project Admin 
change the status of one of the user attendees when clicking on set attendance 
link in the toolbox in view meeting page then the system redirects to Set 
Attendance page where he can change the status of meeting attendees.

Failure Scenarios:
Scenario 1: Given the Scrum Master/Project Admin try to change the status of 
the meeting before the meeting time has passed then the link of set attendance 
will be hidden

Tasks:
Coding,Documentation.

Original issue reported on code.google.com by amoro...@gmail.com on 16 Jun 2010 at 8:34

GoogleCodeExporter commented 8 years ago
Sorry Amr, I want to ask about this. do you mean change the status in general 
to anything? 

In the success, make sure that the user is notified with the change in his 
status which is done by others ;)

What kind of changes that can be made after the deadline had passed?

Peace

Original comment by felsayed...@gmail.com on 16 Jun 2010 at 9:50

GoogleCodeExporter commented 8 years ago
I mean the meeting status(sorry for not clarifying that in the story)... 
attended or not... we added this because for example a user that entered his 
status as attended and did not attend for any reason so the changes of the 
status will be either attended or not attended.

oh yeah Okay a mail will be sent thanks for that :D

This change can only be done by a user who is having the role of setting 
attendance.
Is that's okay ?

Thanks :)

Original comment by amoro...@gmail.com on 16 Jun 2010 at 10:04

GoogleCodeExporter commented 8 years ago
Yes sounds good.

So, there is a permission for changing attendance (of others)  and this one is 
a powerful one which can work even after the meeting has closed or at anytime 

And there is another persmission given to the user to change (his own) 
attendance which should be limited since he shouldn't say that he attended 
after the meeting has expired or it might be misused? 

It is an interesting debatable feature :) And it will clarify with a demo. Let 
me know whenver you have anything working. I am the product owner now and I 
don't have to wait till the demo. I can see partial work ;)

Shokran Amrotto :)

Original comment by felsayed...@gmail.com on 17 Jun 2010 at 8:28

GoogleCodeExporter commented 8 years ago
actually I though it (the permission of changing others attendance) will be 
working after the meeting time is finished (closed) not before to give normal 
users the chance to confirm/decline the invitation.

And for Normal users as you said they will be able to put their attendance 
until the meeting time start (its done in sprint 2 already :D )

Welcome Dr.Fatma :D

Original comment by amoro...@gmail.com on 17 Jun 2010 at 11:05

GoogleCodeExporter commented 8 years ago
Hey Dr.Fatma..

I worked on the story and its 99% working now I just want a feedback on it like 
the UI and If you want any other thing in it...

You can access the story by clicking on any past meeting then set attendance 
(only work with users who have setMeetingAttendance permission) .

Original comment by amoro...@gmail.com on 21 Jun 2010 at 2:37

GoogleCodeExporter commented 8 years ago
Amrotto,

I was able to see set attendance even when the meeting is not closed. I mean it 
will end on 2nd of july.

I thought you meant I can only do that after it is closed.

Also you have the three meetings listed under past meetings, do you mean past 
and current??

Also, about the UI for the set attendance form. It is nice to make a difference 
in color between instructions and the actual form or meat of the work.

The radio buttons definitely have to be aligned for visibility. As if there 
they are in a table.

also, the alerts and messages should be in different color and smaller fonts.
Then, after I successfuly enter the reason, you can just hide the textbox and 
the button.

Put an astrix for the text box  of the reason.

Nice work amrotto :))

Original comment by felsayed...@gmail.com on 21 Jun 2010 at 9:48

GoogleCodeExporter commented 8 years ago
Hey Dr. Fatma...

well we (C2) agreed that the meeting is "past" just when the start time passed 
and you can not send any new invites too... so I worked on it that you can set 
the attendance of the invited users just when the meeting start.

The UI is now changed and the alerts and messages are handled as you said.

So can you please take a look at it and see if this what you was expecting :D..
thanks a lot..

Original comment by amoro...@gmail.com on 21 Jun 2010 at 10:53

GoogleCodeExporter commented 8 years ago
is it possible to allow invites as long as the meeting time is not over?

Imagine we are having a meeting now and you reminded me that someone show be 
invited and most probably, he will be able to see it and get in before the 
meeting expires?

So, why close invites before the meeting expires??

Sorry about the delay but i didn't test your work yet. I will do it today when 
I go home. I had internet issues yesterday.

Thanks amorotto :))

Original comment by felsayed...@gmail.com on 22 Jun 2010 at 2:17

GoogleCodeExporter commented 8 years ago
Looks good amrotto :)
Good job 

I understand that the guy whose status changed is notified, right?

Thank you

Original comment by felsayed...@gmail.com on 22 Jun 2010 at 7:19

GoogleCodeExporter commented 8 years ago

Original comment by amoro...@gmail.com on 26 Jun 2010 at 6:45

GoogleCodeExporter commented 8 years ago
amr ,from where can i change the status of the attendees??? 
ana 3amlt 2 meeting & they are past already ,bas msh 3aref a3'ayer elstatus mnen

also this error popped when i did try to confirm the meeting through the link 
in the notifications .
bas lma 3mlt confirmation mn my invitation ,worked fine
ana msh 3aref dah tab3ak wla la2??,bas 2olt a2olak :D

NullPointerException occured : Try to read status on null object 
models.MeetingAttendance (controllers.MeetingAttendances.confirm, ligne 32)

In /app/controllers/MeetingAttendances.java (around line 32)

28:

29:
    public static void confirm( String meetingHash )
30:
    {
31:
        MeetingAttendance attendance = MeetingAttendance.find( "byMeetingHash", meetingHash ).first();
32:
        String status = attendance.status;
33:
        Date currentDate = new Date();
34:
        Date tempStart = new Date( attendance.meeting.endTime );
35:
        boolean notYet = tempStart.after( currentDate );
36:
        boolean setbefore = false;
37:
        User user = Security.getConnected();
38:
        boolean isUser = false;

Original comment by Moumen.Elteir@gmail.com on 28 Jun 2010 at 9:01

GoogleCodeExporter commented 8 years ago
Amr, could you also please use the note tag for the notes in this page:
http://localhost:9000/meetingattendances/setattendance?meetingID=4

Love your work btw, spectacular! :)

Original comment by mahmoudsakr87 on 2 Jul 2010 at 4:37

GoogleCodeExporter commented 8 years ago

Original comment by amoro...@gmail.com on 25 Jul 2010 at 5:22

GoogleCodeExporter commented 8 years ago
Working like a charm :)

Original comment by galalaly28@gmail.com on 25 Jul 2010 at 11:43