Deprecation warning in GitHub CI

thehanimo / pr-title-checker

An action to automatically check if pull request titles conform to Contribution Guidelines

MIT License

106 stars 36 forks source link

Deprecation warning in GitHub CI #32

Closed mnojek closed 1 year ago

mnojek commented 1 year ago

Hey, thanks for this great tool! I just integrated it into my project and I am playing with it a bit.

I noticed that for each run in the GitHub CI, it returns a deprecation warning for Buffer() method. Full output below:

(node:1568) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

The only place in the codebase when it is used is probably here. Would be great to fix it and make the warning disappear. Regards!

JustJakeCalifornia commented 1 year ago

Hi, I'm getting the same error.

Error: Couldn't retrieve or parse the config file specified - HttpError: Not Found

I also get an error here

Error: Couldn't retrieve or parse the config file specified - HttpError: Not Found

json:

{
  "LABEL": {
    "name": "title needs formatting",
    "color": "EEEEEE"
  },
  "CHECKS": {
    "prefixes": ["fix: ", "feat: "],
    "regexp": "docs\\(v[0-9]\\): ",
    "regexpFlags": "i",
    "ignoreLabels" : ["dont-check-PRs-with-this-label", "meta"]
  },
  "MESSAGES": {
    "success": "All OK",
    "failure": "Failing CI test",
    "notice": ""
  }
}

thehanimo commented 1 year ago

@NicoMarksman your configuration_path in .github/workflows/pr-title-checker.yml is .github/pr-title-checker-config.json by default.

Either change that to .github/workflows/pr-title-checker-config.json OR move your pr-title-checker-config.json to .github/ from .github/workflows/

thehanimo commented 1 year ago

@mnojek this seems to be caused by dependencies that are still using new Buffer() :/

Do you think suppressing this warning would be a good idea so that the output log is more readable?

thehanimo commented 1 year ago

Released v1.3.7!

JustJakeCalifornia commented 1 year ago

That's awesome @thehanimo ! :)

JustJakeCalifornia commented 1 year ago

@NicoMarksman your configuration_path in .github/workflows/pr-title-checker.yml is .github/pr-title-checker-config.json by default.

Either change that to .github/workflows/pr-title-checker-config.json OR move your pr-title-checker-config.json to .github/ from .github/workflows/

So I should move pr-title-checker-config.json to .github/pr-title-checker-config.json?

thehanimo commented 1 year ago

@NicoMarksman your configuration_path in .github/workflows/pr-title-checker.yml is .github/pr-title-checker-config.json by default. Either change that to .github/workflows/pr-title-checker-config.json OR move your pr-title-checker-config.json to .github/ from .github/workflows/

So I should move pr-title-checker-config.json to .github/pr-title-checker-config.json?

Yes

mnojek commented 1 year ago

Thanks @thehanimo! 🙇🏻 I will update the tool and start using it :)