search

thehogfather / brackets-code-folding

Code folding extension for brackets IDE
134 stars 42 forks source link

Not working at all since last update #130

Closed thany closed 9 years ago

thany commented 9 years ago

Since the last update, this plugin doesn't work at all anymore. Nothing. It's as if it just isn't there.

But to prevent a "it doesn't work" issue, I opened up the dev tools to see what's what, and here's what:

Exception when calling a 'brackets done loading' handler:
TypeError: Object #<Object> has no method 'on'
    at init (file:///C:/Users/Martijn/AppData/Roaming/Brackets/extensions/user/brackets-code-folding/main.js:297:27)
    at _callHandler (/utils/AppInit.js:93:13)
    at Object._dispatchReady (/utils/AppInit.js:113:13)
    at Object.eval (/brackets.js:289:33)
    at j (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/thirdparty.min.js:559:26676)
    at Object.k.add [as done] (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/thirdparty.min.js:559:26985)
    at Object.d.always (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/thirdparty.min.js:559:27861)
    at eval (/brackets.js:287:30)
    at j (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/thirdparty.min.js:559:26676)
    at Object.k.fireWith [as resolveWith] (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/thirdparty.min.js:559:27489)

I can't help but suspect this is the cause of Code Folding not working...

I'm using Brackets 1.0 on Windows 7 x64. Also tried with only Code Folding enabled.

thehogfather commented 9 years ago

ok - the reason was due to an upgrade in brackets API. Would you be able to update your brackets to 1.2 or are you using 1.0 for any reason?

I will update the engine requirements for the plugin.

thany commented 9 years ago

I'm using 1.0 because of a scrolling bug that's holding things back for me...

If anything, can you make it so that 1.0 only installs up to the previous version of the plugin, if you can't make the latest one work on 1.0?

thehogfather commented 9 years ago

i've updated the requirements in the registry. Can you uninstall and reinstall?

thany commented 9 years ago

Sorry, it doesn't let me install it at all now...

thehogfather commented 9 years ago

This issue has been fixed in @dd7eef9d57ec7e1d4ac4861ca298299ebd6f23e5

thany commented 9 years ago

Excellent, seems to be working again. Thanks.