search

thehogfather / brackets-code-folding

Code folding extension for brackets IDE
134 stars 42 forks source link

Switching files with code folding enabled is very slow #26

Closed EvHaus closed 11 years ago

EvHaus commented 11 years ago

With the code folding extension enabled, switching between various files in Brackets becomes much much slower. There's a very noticeable 500ms - 2s delay (depending on the size of the file). Almost as if code-foldering is re-calculating the code folding data on file focus.

If that's the case -- shouldn't it only be doing this once during file load, not on every file focus?

In other words -- is there any way to improve performance here?

thehogfather commented 11 years ago

do you notice this immediately brackets is started, or after using the extension for a while? Also what is the typical number of lines in the files being switched? And does the file extension matter?

I'm asking because I have been trying to keep an eye on a possibly related issue which seems to be affected by having multiple brackets windows open.

Cheers

thehogfather commented 11 years ago

Regardless of your answers to the questions above, you made a valid point about improving performance. Could you try an updated version of the extension using the "install through url" option and let me know if there are any noticeable improvements? Cheers

EvHaus commented 11 years ago

This is a slight improvement. Maybe 10%? Not sure how to properly measure this though.

Two files I'm using to switch between. A 7000 line Javascript file, and a 300 line HTML file. Even the HTML file has a significant speed cost with code-folding enabled.

thehogfather commented 11 years ago

Could you test again? There should be some improvements with the latest version.

EvHaus commented 11 years ago

Much better now. Thanks!

However, I noticed that the View > Toggle Code Folding option is no longer available so code folding is on by default. Not sure if this is a bug or new intended behavior.

thehogfather commented 11 years ago

The toggle code folding option from the view menu has been intentionally left out, as well as the context menu for collapsing and expanding all code regions within a file.

Cheers.