search

thehogfather / brackets-code-folding

Code folding extension for brackets IDE
134 stars 42 forks source link

Can't type "]" character when extension is installed and active #34

Closed Shakarhaba closed 10 years ago

Shakarhaba commented 10 years ago

Can't type "]" character when extension is installed and active. I'm running Window 8.1 Pro in Spanish (Spain).

The character not being typed only occurs inside brackets when the extenion is installed and active. I've deleted all other extensions even reinstalled the last version and the bug still occurs.

thehogfather commented 10 years ago

Could you please tell me if there are any error messages in the chrome console when you click Debug -> Show Developer Tools in brackets? In the mean time I will try to reproduce your bug.

thehogfather commented 10 years ago

Could you also let me know if the "]" character is typed using one keystroke on your keyboard or a combination of keys? The reason I ask is that there might be a conflict with a keyboard shortcut in the extension for expanding code regions (Ctrl-Alt-+).

Shakarhaba commented 10 years ago

No errors are being printed to the console. When typing "]" nothing happens as if the key wasn't even pressed at all.

In Spanish keyboards ] character is typed by pressing "AltGr + ]", closing bracket is in the same key that +* symbols.

Shakarhaba commented 10 years ago

Yes, I've tested commenting lines 230 and 234 and now I can type closing bracket symbol, I guess I will have to change those shortcut keys. It would be great if you could inform about this conflict to other users in the extension's main readme so they can change the shortcut.

// CommandManager.register("Expand Current", EXPAND, expandCurrent); // KeyBindingManager.addBinding(EXPAND, "Ctrl-Alt-+");

thehogfather commented 10 years ago

Thanks and yes, I will make the update. And I would appreciate if you let me know what you have changed the shortcut key to. I would like to update the extension at some point to dynamically set the shortcut key based on locale.

Thanks again.

Shakarhaba commented 10 years ago

I have changed the shortcut to expand current to Ctrl-Alt-. For spanish keyboards this next combinations would also work, since the dot key is next to the - key (used to collapse) is the best substitute to +:

Ctrl-Alt-' Ctrl-Alt-¡ Ctrl-Alt-<