search

thehogfather / brackets-code-folding

Code folding extension for brackets IDE
134 stars 42 forks source link

git commiting unfold folded items. #38

Closed RB-Lab closed 10 years ago

RB-Lab commented 10 years ago

Steps to reproduce: (it is assumed that 'brackets-git' extension already installed)

  1. fold some items
  2. add some changes to file
  3. open brackets-git
  4. select there file
  5. hit 'commit' button

Expected behaviour: nothing happened Actual behaviour: every folded items became unfolded.

Notes: It also happens if currently open any other file. But if open (and active) file had been changed and folded, you can see unfolding 'in real time'. Not modified files not unfolds. Steps 2 and 3 may been interchanged.

Maybe this bug refer to brackets-git, I dunno actually.

thehogfather commented 10 years ago

Thanks for reporting this. I have pushed a commit that seems to address the issue. If you had some time to test it that would be great!

RB-Lab commented 10 years ago

Everything looks working well. I tried it in javascript and in html. It blinks but folded items remains folded. Thank you for so quick reaction! Btw, good folding plugin was one of the main reason for me to switch from Komodo and Eclipse/Aptana to Brackets. Thank you for your work!

RB-Lab commented 10 years ago

Sorry I hurried. Only folded items above current screen remains folded. But some folders on the current screen and below it became unfolded. I still can't figure out which ones. It seems that it all folded items in first level and.. maybe that items that shown beside git window?

RB-Lab commented 10 years ago

Nope. Not all folded items above. And not all that in current viewport...

thehogfather commented 10 years ago

Thanks for the info. I shall investigate further.

thehogfather commented 10 years ago

I think this issue has been resolved. Please reopen if you feel otherwise. Cheers.