thehogfather / brackets-code-folding

Code folding extension for brackets IDE
134 stars 42 forks source link

Some optics and keybindings changed, Localization added #41

Closed cortex359 closed 10 years ago

cortex359 commented 10 years ago
thehogfather commented 10 years ago

Thanks a lot for the pull request! I have merged and updated.

I've had to increase the size of the fold-markers a little since they might be a little hard to click with certain display resolutions. Also the keyboard shortcut issues i agree with in principle, but some people might be used to having the collapse/expand all feature e.g. in notepad++ (and as far as my little research could tell, the current shortcuts don't conflict with any keyboard characters - if I am wrong about this, do let me know).

Lastly, (i might be wrong about this but) it seems that Alt-C and Alt-E are currently used to type special characters (é and ç) or € in some locales according to certain online keyboard simulators. Please let me know if this is untrue for the German keyboard as I havent got access to one. The best I can do is to change my OS keyboard locale and use online keyboard simulators.

Cheers.

cortex359 commented 10 years ago

Thanks a lot for the extension! :)

I looked up the shortcuts in notepad++ and saw that the default for folding and unfolding are Alt-0 and Shift-Alt-0, so I tried to change it but I figured out that unfolding with Shift-Alt-0 does not work. It does not produce any errors in the console and I can not find any conflicting key bindings. Do you know why it does not work? Maybe it is a bug in brackets.

The current Ctrl-Alt-C shortcut conflicts with the superClipboard extension, but of course it can't be our job to check every extension for possible conflicts.

I did not know that Alt-C and Alt-E were used for special characters. Really interesting though. On German keyboards it works like the Ctrl key just for functions. Special characters like € or @ are typed with the Alt Gr key which apparently does not even exist on US-Keyboards (ANSI Layout).

The KeyBindingManager has the function _isKeyAssigned, but for some reasons it is private so we can not use it to define a fallback.

thehogfather commented 10 years ago

I was unaware of the conflict with superClipboard -- the author must have forgotten to add their shortcuts to the (brackets shortcut homepage)[https://github.com/adobe/brackets/wiki/Brackets-Shortcuts] because I could not find it there when I assigned that shortcut.

Not quite sure why Shift-Alt-0 doesnt work. Not sure if it was related to why I chose to use Shift-Alt-1 instead.