search

thehogfather / brackets-code-folding

Code folding extension for brackets IDE
134 stars 42 forks source link

Refactor of almost the entire extension... #53

Closed FezVrasta closed 10 years ago

thehogfather commented 10 years ago

thanks.

FezVrasta commented 10 years ago

You can't use CodeMirror from global scope.

Use brackets.getModule("thirdparty/CodeMirror2/lib/codemirror") instead of global CodeMirror.
at Object.defineProperty.get (file:///C:/Program%20Files%20(x86)/Brackets/dev/src/brackets.js:114:32)
at Object.<anonymous> (file:///C:/Users/<username>/AppData/Roaming/Brackets/extensions/user/brackets-code-folding/foldhelpers/xml-fold.js:12:15)
at Object.context.execCb (file:///C:/Program%20Files%20(x86)
thehogfather commented 10 years ago

This is true for the bleeding edge brackets code in git (Sprint 38). However most people use and install the stable version (Sprint 37 and lower), so we cannot make this update yet. If you try to use brackets.getModule(...) to get the CodeMirror object in the stable release it throws an error.

FezVrasta commented 10 years ago

Oh I didn't know this, I thought was something already compatible. Sorry for that so.