search

thehogfather / brackets-code-folding

Code folding extension for brackets IDE
134 stars 42 forks source link

Cant fold custom comments #90

Open abdelouahabb opened 10 years ago

abdelouahabb commented 10 years ago

it seems the code folding for comments has a problem when it is a language mixed (html mixed) if i add:

blockComment: ["{#", "#}"],

to the extension that make highlighting for Django templates, it dont detect the comments as folds.

https://github.com/abdelouahabb/django-brackets/blob/master/main.js

thehogfather commented 10 years ago

Hi I have had a look at both your extensions (ref #91). I think the problem is with the code mirror modes for the two languages. Essentially, normally, the characters that signal the beginning of a comment are tokenised as part of the comment and not a tag.

You can also see that it is not a mixed language problem because (region) codefolding works fine in html and javascript mixtures. I'll have a go at a more accurate tokenisation and see if that makes a difference.

abdelouahabb commented 10 years ago

yes, this is what made me ask the question, i tested with html/js/css comments and they are detected, but the one i added by the extension are rejected.

thehogfather commented 10 years ago

django and tornado should now have brace folding enabled. Test using the latest version from git and let me know if it solves your issues.

abdelouahabb commented 10 years ago

still the same think, the code has to be indented to have the folding,

sans titre