search

thehookup / Holiday_LEDs_2.0

Tested and 100% working, this new version is easier to setup and can support 6 zones dynamically
199 stars 36 forks source link

Optimize code #19

Open zskullz opened 4 years ago

zskullz commented 4 years ago

Use animation functions instead of copy paste for each zone and section

zskullz commented 4 years ago

This will make the code much easier to maintain for a few reason. If a change, fix or customization is needed for an animation, it can be done in one place; If a new animation is added, the function doesn't need to be duplicated for every zone/section; It will require less code to add additional zones/sections.

zskullz commented 4 years ago

Great example of how copy-paste can go wrong :)

gniknalu commented 4 years ago

My Set-up uses three zones. Fireworks is awesome! Heartbeat is cool! Can't seem to get "Ripple" to work. It is just a solid fill. (Maybe there is a config change that wasn't obvious that I missed for HA and/or MQTT?)

zskullz commented 4 years ago

My Set-up uses three zones. Fireworks is awesome! Heartbeat is cool! Can't seem to get "Ripple" to work. It is just a solid fill. (Maybe there is a config change that wasn't obvious that I missed for HA and/or MQTT?)

Ripple is something I believe TheHookup was working on, i haven't figured out what it is suppose to do or gotten it to work yet. I did just add some major changes though and would love your feedback on them.