search

thehookup / Holiday_LEDs_2.0

Tested and 100% working, this new version is easier to setup and can support 6 zones dynamically
199 stars 36 forks source link

Make LED type a variable #4

Closed ad8mustanggt closed 5 years ago

ad8mustanggt commented 5 years ago

Would you be open to making the LED type a variable instead of hard-coded WS2812B? It took me a little bit to figure out why my WS2811 strings were working, but not well, until I realized I hadn't seen the LED type defined at the top. Doing a quick find and replace isn't a big deal, just one more thing I need to remember to do!

Not sure if you would like issues opened so you can do the modifications or if you would accept a pull requests for these types of things.

Edit: So this doesn't seem to be my issue after all but might still be nice to have.

thehookup commented 5 years ago

The reason I didn't include it is that I don't think 2811 vs 2812B actually changes anything. If you're using a strip with a clock pin it needs to be setup differently, but 2811 and 2812B work with either definition.

Did you get your issue figured out?

thehookup commented 5 years ago

Going to close this just for OCD sake, if you figure out there is an issue running 2811s on the 2812B definition please reopen and I'll add it. It just seemed like an area that could confuse people if I put it in the user config section.

ad8mustanggt commented 5 years ago

Yeah - After looking at the FastLED github page it looks like they all fall under the neopixel category (plus I didn't see any noticeable difference after changing it).

I haven't. I'll post a video of the issue but the lights seem to randomly flash/blink out of sequence. Static colors work fine but anytime I use an animation I get the random blinking.