Include block included/finalization status in transaction/batch storage - Githubissues

thehubbleproject / hubble-contracts

Hubble optimistic rollup

https://thehubbleproject.github.io/docs/

MIT License

133 stars 28 forks source link

Include block included/finalization status in transaction/batch storage #592

Open jacque006 opened 3 years ago

jacque006 commented 3 years ago

Related: https://github.com/thehubbleproject/hubble-contracts/issues/548

What's wrong

Block included (finalization) data is not included in metadata for transactions and batches

How we can solve

Have node track when new ETH blocks are mined and what the current block number is.
Update transaction and batch metadata when the current block = batch submitted block + BLOCKS_TO_FINALISE so consumers know when a transaction or batch is locked in.

Consider

How many confirmations do we need to consider a block mined? We currently use 1 in many places, but might be worth adding another constant to set this.