Closed kautukkundan closed 3 years ago
Some notes -
I addition, one downside of this is that all endpoints will return this status including our process health check (/health) which would be used by container orchestration platforms and uptime checks in general to make sure the node is still responding to pings. We should have the hook ignore /health or consider adding the hook only to the endpoints registered in RPC.ts.
I guess this is sorted as the fastify hook only applies to the fastify endpoints. since the /health
endpoint is created with the terminus, it does not have the onRequest
hook applied to it. I have manually tested this as well.
For testing, given the amount or work it will involve to setup I think we can skip for now. Manual testing is good :+1:
closes #558