search

thehubbleproject / hubble-contracts

Hubble optimistic rollup
https://thehubbleproject.github.io/docs/
MIT License
133 stars 28 forks source link

Include subtreeID and depositCount in DepositQueued event in IDepositManager #637

Closed jacque006 closed 3 years ago

jacque006 commented 3 years ago

Problem

When a deposit is queued using DepositManager.depositFor, it is difficult as a contract consumer to determine what subtree the deposit will become part of and how many deposits are currently part of that subtree. This also makes it difficult to correlate the deposit to the DepositsFinalised event from Rollup.submitDeposits.

Solution

Add uint256 subtreeID and uint256 depositCount to the IDepositManager.DepositQueued event.