search

thehubbleproject / hubble-contracts

Hubble optimistic rollup
https://thehubbleproject.github.io/docs/
MIT License
133 stars 28 forks source link

Add subtreeID, depositCount to DepositQueued event #638

Closed jacque006 closed 3 years ago

jacque006 commented 3 years ago

Resolves https://github.com/thehubbleproject/hubble-contracts/issues/637

jacque006 commented 3 years ago

Gas changes

master

Screenshot from 2021-07-29 11-39-53 Deposit 0: 139601 Deposit 1: 109921

This PR

Deposit 0: 142214 Deposit 1: 110336 Deposit 2: 108026

cha-cha-cha-changes

Screenshot from 2021-07-30 10-59-45 Deposit 0 change: +2613 Deposit 0 % change: +1.871%

Deposit 1 change: +415 Deposit 1 % change: +0.378%

Deposit 2 N/A

jacque006 commented 3 years ago

Thanks for the help @ChihChengLiang ! Suggestions implemented, gas stats updated, slight decrease :tada:

kautukkundan commented 3 years ago

Suggestion - we can start using hardhat-gas-reporter. It also comes with codechecks plug-in which can compare gas change with the target branch so we don't need to calculate manually!

jacque006 commented 3 years ago

@kautukkundan I have a branch up that would add contract test coverage as well as hopefully implement the reporter you mentioned https://github.com/thehubbleproject/hubble-contracts/pull/552 . We would need to update a number of spots for it to work properly but I agree that it would be much easier than manually calculating and reporting in PRs :)