search

thehubbleproject / hubble-contracts

Hubble optimistic rollup
https://thehubbleproject.github.io/docs/
MIT License
133 stars 28 forks source link

Make DepositQueued.depositID start at 0 instead of 1 #642

Closed jacque006 closed 3 years ago

jacque006 commented 3 years ago

Original discussion: https://github.com/thehubbleproject/hubble-contracts/pull/636#discussion_r681398634

Problem

Currently, DepositManager.DepositQueued.depositID starts at 1 for its IDs. Most of our other IDs are 0 based indexes (stateID, pubkeyID, etc.)

Solution

Change depositID to be 0 index based (start at 0)

jacque006 commented 3 years ago

Remember to remove https://github.com/thehubbleproject/hubble-contracts/pull/636/files#diff-ffa6856c7a4dc98609b78103141fa71cf9c9d5e1135962b1f0aad38456f330ebR82 as part of this work.