thehubbleproject / hubble-contracts

Hubble optimistic rollup
https://thehubbleproject.github.io/docs/
MIT License
133 stars 28 forks source link

Revert in C2T dispute #653

Open dmaretskyi opened 3 years ago

dmaretskyi commented 3 years ago

In the case there's a C2T transaction to a non-empty state leaf, the dispute would trigger a revert which makes it impossible to dispute this fradulent transaction.

Here's the line that triggers a dispute: https://github.com/thehubbleproject/hubble-contracts/blob/003235445e3b625211ed19de49bff6575a8bc94e/contracts/libs/Transition.sol#L99

I think the fix would be to return an Ok/Error status like in the other processTransition* functions.