search

thehubbleproject / hubble-contracts

Hubble optimistic rollup
https://thehubbleproject.github.io/docs/
MIT License
133 stars 28 forks source link

Allow disputing Create2Transfer with nonexistent receiver #670

Closed b-tarczynski closed 2 years ago

b-tarczynski commented 2 years ago

Resolves https://github.com/thehubbleproject/hubble-contracts/issues/669

jacque006 commented 2 years ago

This looks fine to me, similar to work in https://github.com/thehubbleproject/hubble-contracts/pull/655 but much more explicit for zero/empty case.

@ChihChengLiang can you take a look as well?

@b-tarczynski it would be good to have test case for this as well, likely can be added in https://github.com/thehubbleproject/hubble-contracts/blob/master/test/slow/rollup.create2Transfer.test.ts

b-tarczynski commented 2 years ago

This looks fine to me, similar to work in #655 but much more explicit for zero/empty case.

@ChihChengLiang can you take a look as well?

@b-tarczynski it would be good to have test case for this as well, likely can be added in https://github.com/thehubbleproject/hubble-contracts/blob/master/test/slow/rollup.create2Transfer.test.ts

I added test for these changes as you suggested

jacque006 commented 2 years ago

Docker CI failure can be ignored, unrelated to this work.