search

thehyve / cbioportal-docker

A context to create cBioPortal docker images
7 stars 18 forks source link

Add MAVEN_OPTS env var to extends mvn behavior for example proxy stuff. #31

Closed gautric closed 3 years ago

gautric commented 6 years ago

Maven command line is to restrictive. We could provide MAVEN_OPTS to deal with infra or technical stuff (proxy, profile, custom env)

fedde-s commented 5 years ago

I'd understood proxy configuration to be covered by the build args that Docker predefines automatically. And I think even that shouldn't be needed very often anymore, now that downloading a pre-built image for a reviewed cBioPortal release and attaching a custom configuration file should almost always be preferable to deploying a tweaked image in production.

fedde-s commented 5 years ago

Is there a use-case that I'm missing there?

fedde-s commented 5 years ago

I'm not sure there is anymore, now that nearly all configuration that affects runtime has been moved out of the image, and the image built on a development machine or build server can be deployed verbatim to production servers.