thehyve / ot-ui-apps

Apache License 2.0
1 stars 0 forks source link

Remove unused Dockerfiles from ot-ui-apps #26

Open AnikaBongaarts opened 6 months ago

AnikaBongaarts commented 6 months ago

There are two supposedly obsolete Dockerfiles in ot-ui-apps:

thehyve/ot-ui-apps:apps/genetics/Dockerfile thehyve/ot-ui-apps:apps/platform/Dockerfile We should remove them (open PR to EBI repo) and, in the meantime, exclude them from the Snyk dashboard so we don’t keep getting vulnerability warnings.

AnikaBongaarts commented 6 months ago

Old comments: Removing them in the patch in which we add the actual up-to-date Dockerfile sounds great! That commit is basically an update to code that’s already there, as I tried to argue a while back, so it’s counterproductive to keep the old and new Dockerfiles in the repo side by side like we’re doing now. Regardless of whether we present the update and intention to keep contributing updates to EBI afterwards.

Actually on Snyk scanning of these images already appear as inactive (there is an “Activate” button next to them), but they are not hidden in the list so it’s easy to think they are still being tracked (like I did)