Display placeholder even if options are selected

thehyve / react-select-checked

A React select component based on JedWatson/React-Select with checkmarks on selected options.

GNU General Public License v3.0

9 stars 5 forks source link

Display placeholder even if options are selected #19

Closed fedde-s closed 6 years ago

fedde-s commented 6 years ago

This should fix #17.

rnugraha commented 6 years ago

I just tested the fix, apparently, the placeholder also appears when search keywords is still being typed. I guess we need to have another validation for this.

schermafbeelding 2018-05-29 om 17 55 33

fedde-s commented 6 years ago

Oops! Yes, that's wrong. Glad you tested it!

fedde-s commented 6 years ago

I added a commit to address the issue. Unfortunately it does involve keeping some state in the component, as react-select doesn't expose the search text as an external prop.

rnugraha commented 6 years ago

:+1: