search

thehyve / react-select-checked

A React select component based on JedWatson/React-Select with checkmarks on selected options.
GNU General Public License v3.0
9 stars 5 forks source link

‘Add all’ deselects currently invisible options #4

Closed fedde-s closed 6 years ago

fedde-s commented 6 years ago

If I:

  1. select an option in the dropdown (say, ‘Peppermint’) and then
  2. make it invisible, either by searching/filtering for prefixes not in my selection (say, ‘Co’ to match both ‘Cookies and Cream’ and ‘Coconut’) or by externally changing the options= prop, and I subsequently
  3. press the Add all button,

then

  1. this does not only cause the component to select all currently visible options, but also to deselect the now-invisible one.

I believe that this is not the intended behaviour, as the Clear all button only deselects visible values while leaving invisible ones untouched.

fedde-s commented 6 years ago

I proposed a fix for this in pull request #5.

rnugraha commented 6 years ago

5 merged