search

thehyve / react-select-checked

A React select component based on JedWatson/React-Select with checkmarks on selected options.
GNU General Public License v3.0
9 stars 5 forks source link

Leave invisible options untouched on ‘Add all’ #5

Closed fedde-s closed 6 years ago

fedde-s commented 6 years ago

To be consistent with the 'Clear all' button, the 'Add all' button should only add all currently visible options to the selection. Invisible (i.e. filtered or currently nonexistent) options should be left as-is, selected or unselected. This is a fix for issue #4.

fedde-s commented 6 years ago

I applied both your suggestions. Would you like me to squash the new changes with the commits that introduced the code in the first place?