thehyve / react-select-checked

A React select component based on JedWatson/React-Select with checkmarks on selected options.
GNU General Public License v3.0
9 stars 5 forks source link

Selected highlight moves one option below after selecting an option #7

Open rnugraha opened 6 years ago

rnugraha commented 6 years ago

The highlight ideally should stay on the selected item.

fedde-s commented 6 years ago

I noticed, but this bug seems to also exist in the underlying react-select component itself for multiselect inputs where both the removeSelected= and closeOnSelect= props are set to false. We should report the bug there.

fedde-s commented 6 years ago

I informed the upstream project of the buggy appearance by filing issue JedWatson/react-select#2169.

fedde-s commented 6 years ago

This should be fixable once this react-select commit is included in a release: https://github.com/JedWatson/react-select/commit/641d1eeb3b5dd0a02511c4c1e5ee340f48de2877

fedde-s commented 6 years ago

Would moving to version v1.3.0 of the underlying react-select library in order to resolve this issue break things? Of course the version number suggests that there should be no backwards-incompatible changes, but still.